Bugzilla Reviewers, By File

Table of Contents

About This Page

This is a list of who to ask for review, depending on which files you are changing. These people are essentially the "owners" of these files.

If a file lists more than one reviewer, you can pick any one.

You may ask any reviewer to review any change to any file, but they may defer it to another reviewer if they do not feel qualified. They will probably defer it to the reviewer on this list.

Changes That Touch More Than One File

If your change touches many files, try to pick the file that's at the "heart" of the changes, and ask that person for review. If you can't figure out who to ask for review, each section has a list of "general" reviewers for that area of Bugzilla. Just pick one of them.

Areas of Expertise

Some reviewers have areas of expertise that are not related to any specific part of Bugzilla. If you would like a review about one of these areas, ask these reviewers.

Area Reviewer(s)
Code Style mkanat
CSS glob, mkanat
JavaScript pyrzak, mkanat
Group Security mkanat, LpSolit
Windows-Specific Issues glob
SQL mkanat
PostgreSQL + Oracle mkanat
User Interface pyrzak

CGIs

If there is no person listed for a particular file, then there is no currently assigned reviewer for that file.

The following reviewers are currently available to do reviews on any CGI file, and are likely to actually respond to your review request:

  • LpSolit
  • mkanat

Pick one of the above reviewers if there is no reviewer listed for a particular file.

File Reviewer(s)
edit*.cgi (admin CGIs) LpSolit, mkanat
attachment.cgi LpSolit
request.cgi LpSolit
buglist.cgi wicked, mkanat
chart.cgi wicked, gerv
createaccount.cgi
colchange.cgi
config.cgi
describecomponents.cgi LpSolit
describekeywords.cgi wicked
duplicates.cgi gerv
enter_bug.cgi LpSolit (OS Detection: timeless)
index.cgi
jsonrpc.cgi mkanat
page.cgi gerv
post_bug.cgi LpSolit
process_bug.cgi LpSolit
query.cgi wicked
quips.cgi wicked
relogin.cgi
report.cgi gerv
reports.cgi gerv
sanitycheck.cgi LpSolit
show_activity.cgi
show_bug.cgi mkanat
showdependencygraph.cgi justdave
showdependencytree.cgi
summarize_time.cgi LpSolit
testagent.cgi
token.cgi LpSolit
userprefs.cgi wicked
votes.cgi LpSolit
xmlrpc.cgi mkanat

Non-CGI (.pl) Scripts

The generally available reviewers for non-CGI scripts are the same as those for CGI scripts.

The Test Suite

The test suite consists of runtests.pl and all the files in the t/ directory.

Reviewers for the test suite are:

  • gerv

Other Scripts

File Reviewer(s)
checksetup.pl mkanat
collectstats.pl gerv
email_in.pl mkanat
importxml.pl LpSolit
testserver.pl glob
whineatnews.pl wicked
whine.pl wicked

Libraries (.pm files)

These are the files in the Bugzilla/ directory.

The following reviewers are currently available to do reviews on any library, and are likely to actually respond to your review request:

  • mkanat@bugzilla.org
File Reviewer(s)
Attachment.pm LpSolit
Auth.pm
Bugzilla/Auth/*
mkanat
BugMail.pm wicked, gerv
Bug.pm mkanat
BugUrl.pm
Bugzilla/BugUrl/*
timello
Bugzilla.pm mkanat
CGI.pm glob
Chart.pm wicked, gerv
Classification.pm mkanat, LpSolit
Component.pm mkanat, LpSolit
Config.pm
Config/*.pm LpSolit
Constants.pm
DB.pm
Bugzilla/DB/*
mkanat
Error.pm
Field.pm
Flag.pm LpSolit
FlagType.pm LpSolit
Group.pm
Hook.pm
Install.pm mkanat
Keyword.pm mkanat
Mailer.pm mkanat, wicked
Milestone.pm mkanat, LpSolit
Object.pm mkanat
Product.pm mkanat, LpSolit
RNG.pm mkanat, glob
Search.pm mkanat, justdave
Series.pm wicked, gerv
Template.pm
Bugzilla/Template/Plugin/*
Token.pm LpSolit
Update.pm LpSolit
User.pm mkanat
User/Setting.pm mkanat
Util.pm mkanat, LpSolit
Version.pm mkanat, LpSolit
WebService.pm
Bugzilla/WebService/*
mkanat, dkl

Templates

In general, templates are reviewed by the same people who own the associated CGIs.

Documentation

For reviews on documentation, make sure that you request them from documentation@bugzilla.bugs.

List Of All Reviewers

The following is a list of all people currently authorized to approve/deny review on patches. Some are component owners, others just like to help out.

All changes to this list must be approved by Dave Miller.

In general, instead of picking a random person from this list to review your patch, you should instead find the appropriate section on this page for the file you are modifying, and ask the appropriate person for review.

NameBugzilla User ID
Frédéric Buclin LpSolit@gmail.com
Byron Jones glob@mozilla.com
Max Kanat-Alexander mkanat@bugzilla.org
Dave Lawrence dkl@mozilla.com
Teemu Mannermaa wicked@sci.fi
Gervase Markham gerv@mozilla.org
Tiago Mello timello@linux.vnet.ibm.com
Dave Miller justdave@bugzilla.org

Become a Reviewer!

Think you'd make a good reviewer? With the rapidly-growing Bugzilla community, we're increasingly needing good reviewers. We generally require that you've submitted some patches of your own so that we can tell you know what you're doing. If you are interested, contact Dave Miller, Bugzilla Project Manager, and let him know you'd like to help out. If Dave agrees that you're ready to become a reviewer, you will be added to this page. You may be asked to spend some more time developing and submitting patches, so we can get to know you better first.

Updates to This Page

mkanat@bugzilla.org is the author of this page. If you would like to be added or removed from any of the areas listed on this page, please contact Max and he would be glad to help you out, or (assuming you are already a reviewer, of course) make the change to the top part of this page yourself if you have CVS access to the website. If you are interested in being added to this list, see the section Become a Reviewer above.

Note to Core Bugzilla Developers

The lists of suggested reviewers for a particular area or file are merely suggestions. If you know that another developer would be more suited for a particular review or has more time, feel free to ask another person than those listed for each file, provided that the reviewer appears on the List of All Reviewers